Fix to LDAP RO group validation and CLI credentials quoting #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instruct the urllib quote function to also quote '/'.
Make sure the LDAP RO group name is encoded before validating whether the user is member of it or not.
houndci-bot
reviewed
Nov 4, 2024
| @@ -569,7 +571,7 @@ def authenticate(self): | |||
| # if ro_group is configured, and the user is a member of | |||
| # neither the ro_group nor the rw_group, fail authentication. | |||
| if self._ldap_ro_group: | |||
| if self._ldap_ro_group not in res[0][1].get('memberOf', []): | |||
| if self._ldap_ro_group.encode('utf-8') not in res[0][1].get('memberOf', []): | |||
There was a problem hiding this comment.
line too long (100 > 79 characters)
| @@ -553,6 +553,8 @@ def authenticate(self): | |||
| ['cn', 'memberOf'], | |||
| ) | |||
|
|
|||
| self._logger.debug("User %s is member of groups: %s", self.username, res[0][1].get('memberOf', [])) | |||
There was a problem hiding this comment.
line too long (111 > 79 characters)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The read-only group name validation was missing an UTF-8 encode.
Improved the quoting of the credentials made by the CLI.